[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 14 18:38:16 PST 2020


kbobyrev added a comment.

The patch could be shorter and slightly less confusing if I preserved 1:1 `RefKind::Implicit` <-> `index::SymbolKind::Implicit` relation, but I thought we might want to keep `RefKind` being 1 byte so that we don't waste unnecessary memory. Also, since we might want to start using `findExplicitReferences` (or something else we come up with) for indexing, it shouldn't be critical. Let me know if you think it's unnecessary.

+CC @hokein


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72746/new/

https://reviews.llvm.org/D72746





More information about the cfe-commits mailing list