[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 14 17:22:27 PST 2020
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
In D72405#1818237 <https://reviews.llvm.org/D72405#1818237>, @zahen wrote:
> I had no luck converting the CHECK-FOO & CHECK-NOFOO tests to use `-verify` because the errors were reported against "(frontend)"
I converted what I could over to `-verify` and switched to testing clang -cc1.
I think this looks good, I'm going to land it, since that's what I've done for you in the past. We have git now, it'll be attributed properly and all that. :)
Let me know if you get commit access in the future to push your own patches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72405/new/
https://reviews.llvm.org/D72405
More information about the cfe-commits
mailing list