[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

[Hubert Tong via Phabricator via cfe-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/Support/FileUtilities.h:44
+    if (!FuncAddr) {
+      return "";
+    }
----------------
I'm not sure that this function should handle failure by returning an empty string. The error condition can be made explicit by making the return type of the function `llvm::Expected<SmallString<128>>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72736/new/

https://reviews.llvm.org/D72736