[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

[Steven Noonan via Phabricator via cfe-commits]

tycho added a subscriber: merge_guards_bot.
tycho added a comment.

In D72404#1820461 <https://reviews.llvm.org/D72404#1820461>, @merge_guards_bot wrote:

> {icon times-circle color=red} Unit tests: fail. 61858 tests passed, 1 failed and 781 were skipped.
>
>   failed: Clang.CodeGen/thinlto-debug-pm.c


I think that failure can be fixed with something like this:

  diff --git a/clang/test/CodeGen/thinlto-debug-pm.c b/clang/test/CodeGen/thinlto-debug-pm.c
  index 5f449d493af..15f366dc52d 100644
  --- a/clang/test/CodeGen/thinlto-debug-pm.c
  +++ b/clang/test/CodeGen/thinlto-debug-pm.c
  @@ -13,17 +13,17 @@
   // O0123sz-NEWPM: Running analysis: PassInstrumentationAnalysis
   // O0123sz-NEWPM: Starting llvm::Module pass manager run.
   // O0123sz-NEWPM: Running pass: WholeProgramDevirtPass
  -// O0123sz-NEWPM: Running analysis: InnerAnalysisManagerProxy<llvm::AnalysisManager<llvm::Function>, llvm::Module>
  +// O0123sz-NEWPM: Running analysis: InnerAnalysisManagerProxy<llvm::FunctionAnalysisManager, llvm::Module>
   // O0123sz-NEWPM: Running pass: LowerTypeTestsPass
   // O0123sz-NEWPM: Invalidating all non-preserved analyses for:
  -// O0123sz-NEWPM: Invalidating analysis: InnerAnalysisManagerProxy<llvm::AnalysisManager<llvm::Function>, llvm::Module>
  +// O0123sz-NEWPM: Invalidating analysis: InnerAnalysisManagerProxy<llvm::FunctionAnalysisManager, llvm::Module>
   // O123sz-NEWPM: Running pass: ForceFunctionAttrsPass
   // O123sz-NEWPM: Running pass: PassManager<llvm::Module>
   // O123sz-NEWPM: Starting llvm::Module pass manager run.
   // O123sz-NEWPM: Running pass: PGOIndirectCallPromotion
   // O123sz-NEWPM: Running analysis: ProfileSummaryAnalysis
   // O123sz-NEWPM: Running pass: InferFunctionAttrsPass
  -// O123sz-NEWPM: Running analysis: InnerAnalysisManagerProxy<llvm::AnalysisManager<llvm::Function>, llvm::Module>
  +// O123sz-NEWPM: Running analysis: InnerAnalysisManagerProxy<llvm::FunctionAnalysisManager, llvm::Module>
   // O123sz-NEWPM: Running pass: ModuleToFunctionPassAdaptor<llvm::PassManager<llvm::Function> >
   // O123sz-NEWPM: Running analysis: PassInstrumentationAnalysis on foo
   // O123sz-NEWPM: Starting llvm::Function pass manager run.
  @@ -41,9 +41,9 @@
   // O123sz-NEWPM: Running pass: CalledValuePropagationPass
   // O123sz-NEWPM: Running pass: GlobalOptPass
   // O123sz-NEWPM: Invalidating all non-preserved analyses for:
  -// O123sz-NEWPM: Invalidating analysis: InnerAnalysisManagerProxy<llvm::AnalysisManager<llvm::Function>, llvm::Module>
  +// O123sz-NEWPM: Invalidating analysis: InnerAnalysisManagerProxy<llvm::FunctionAnalysisManager, llvm::Module>
   // O123sz-NEWPM: Running pass: ModuleToFunctionPassAdaptor<llvm::PromotePass>
  -// O123sz-NEWPM: Running analysis: InnerAnalysisManagerProxy<llvm::AnalysisManager<llvm::Function>, llvm::Module>
  +// O123sz-NEWPM: Running analysis: InnerAnalysisManagerProxy<llvm::FunctionAnalysisManager, llvm::Module>
   // O123sz-NEWPM: Running analysis: DominatorTreeAnalysis on foo
   // O123sz-NEWPM: Running analysis: PassInstrumentationAnalysis on foo
   // O123sz-NEWPM: Running analysis: AssumptionAnalysis on foo


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72404/new/

https://reviews.llvm.org/D72404