[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202
+- New alias :doc:`performance-prefer-pre-increment
+  <clang-tidy/checks/performance-prefer-pre-increment>` to
+  :doc:`llvm-prefer-pre-increment
+  <clang-tidy/checks/llvm-prefer-pre-increment>` was added.
----------------
njames93 wrote:
> lebedev.ri wrote:
> > Are we **really** **really** sure this is the correct relation direction?
> > This isn't an llvm-specific guideline that may be applicable to other code,
> > but a known generic C++ guideline that llvm coding guide follows.
> You're probably right, I added this to llvm first, then thought about alias. Which module should its primary be
> I'd say performancepersonally. Cppcoreguidelines has [[ https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#enforcement-8 | 1 little note ]] about it but I dont think that justifies putting the check in there.
I would agree with `performance` module.
Putting it in cppcoreguidelines would be the same - why there, it's not an Cppcoreguidelines invention?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72553/new/

https://reviews.llvm.org/D72553