[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 14 10:51:40 PST 2020
njames93 added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:29
+public:
+ RenamerClangTidyCheck(StringRef CheckName, ClangTidyContext *Context);
+ ~RenamerClangTidyCheck();
----------------
Should this be protected as this class should never be instantiated directly. Also the definition could be moved inline as its just a delegating constructor
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72284/new/
https://reviews.llvm.org/D72284
More information about the cfe-commits
mailing list