[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

[Rong Xu via cfe-commits]

Thanks for reviewing this.

The new constructor is to avoid initializing the "OS" field (which is not
used by the empty BackendConsumer. Setting this field will affect the
output). I will add a comment there.

-Rong

On Mon, Jan 13, 2020 at 4:50 PM Teresa Johnson via Phabricator <
reviews at reviews.llvm.org> wrote:

> tejohnson accepted this revision.
> tejohnson added a comment.
> This revision is now accepted and ready to land.
>
> LGTM. One more request for a comment below that I forgot to add earlier.
>
>
>
> ================
> Comment at: clang/lib/CodeGen/CodeGenAction.cpp:154
>      }
> +    BackendConsumer(BackendAction Action, DiagnosticsEngine &Diags,
> +                    const HeaderSearchOptions &HeaderSearchOpts,
> ----------------
> Add comment as to what specific case this new constructor is for.
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D72523/new/
>
> https://reviews.llvm.org/D72523
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200114/cadc0373/attachment.html>