[PATCH] D68115: Zero initialize padding in unions

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D68115#1811091 <https://reviews.llvm.org/D68115#1811091>, @lebedev.ri wrote:

> In D68115#1811089 <https://reviews.llvm.org/D68115#1811089>, @hubert.reinterpretcast wrote:
>
> > In D68115#1810891 <https://reviews.llvm.org/D68115#1810891>, @lebedev.ri wrote:
> >
> > > Does this have to be an unilateral change,
> > >  likely penalizing non-`-ftrivial-auto-var-init=` cases,
> > >  i.e. [why] can't it be **only** done for when `-ftrivial-auto-var-init=` is enabled?
> >
> >
> > We left off near that conclusion (https://reviews.llvm.org/D68115#1686887);
>
>
> Would be great if @rsmith / @aaron.ballman could comment on that


I don't have super strong opinions on it, but I think a separate feature for zeroing union padding is what gives users the most flexibility.

In D68115#1811089 <https://reviews.llvm.org/D68115#1811089>, @hubert.reinterpretcast wrote:

> A separate option to control zeroing for union padding would help in cases where the zeroing does not happen for reasons other than `-ftrivial-auto-var-init`.


Agreed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68115/new/

https://reviews.llvm.org/D68115