[PATCH] D72621: PR44514: Fix recovery from noexcept with non-convertible expressions

[Erich Keane via Phabricator via cfe-commits]

erichkeane marked an inline comment as done.
erichkeane added inline comments.


================
Comment at: clang/lib/Sema/SemaExceptionSpec.cpp:90-92
+    llvm::APSInt Value{1};
+    Value = 0;
+    return ConstantExpr::Create(Context, BoolExpr, APValue{Value});
----------------
aaron.ballman wrote:
> This can be simplified with `APSInt::getUnsigned()` unless you reallllly need it to be a one-bit integer.
We normally DO create it as a 1 bit APSInt (the return type of the ConstantExpr), as discussed on IRC we should probably not differ from that.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72621/new/

https://reviews.llvm.org/D72621