[PATCH] D72621: PR44514: Fix recovery from noexcept with non-convertible expressions

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a simplification. Can you mention the LLVM bug report in the commit log, as well (and close the bug)?



================
Comment at: clang/lib/Sema/SemaExceptionSpec.cpp:90-92
+    llvm::APSInt Value{1};
+    Value = 0;
+    return ConstantExpr::Create(Context, BoolExpr, APValue{Value});
----------------
This can be simplified with `APSInt::getUnsigned()` unless you reallllly need it to be a one-bit integer.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72621/new/

https://reviews.llvm.org/D72621