[PATCH] D72634: [clangd] Improve ObjC property handling in SelectionTree.

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 13 11:03:54 PST 2020


dgoldman requested changes to this revision.
dgoldman added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:347
+          )cpp",
+          "ObjCPropertyRefExpr"},
+
----------------
Please add a test for the case mentioned in https://github.com/clangd/clangd/issues/253 as well (for implicit property refs) even though it should also be a ObjCPropertyRefExpr


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72634/new/

https://reviews.llvm.org/D72634





More information about the cfe-commits mailing list