[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 13 10:26:03 PST 2020
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/Hover.cpp:552
+ // For functions we display signature in a list form, e.g.:
+ // Generates `x` from:
+ // - `bool param1`
----------------
Comment needs updating
================
Comment at: clang-tools-extra/clangd/Hover.cpp:567
+ } else if (Type) {
+ Output.addParagraph().appendText("Type: ").appendCode(*Type);
}
----------------
consider **`∈`**, which would be short and symmetrical with the arrow for return type...
Too obscure?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72623/new/
https://reviews.llvm.org/D72623
More information about the cfe-commits
mailing list