[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

Mon Jan 13 07:25:48 PST 2020

kadircet added a comment.

In D72498#1817070 <https://reviews.llvm.org/D72498#1817070>, @sammccall wrote:

> No, I think printing *both* is at least somewhat likely to be too verbose, especially since the previous release showed no types at all.
>  And we're out of time to iterate on the behavior and presentation for this cycle. I think we should do something more conservative and then experiment in the next release cycle.

Sorry, I didn't mention it explicitly in my previous post but I was also planning to make it a separate patch, independent of this one. I am also OK with landing it after branch cut.

As for this patch, I still believe there's a lot of value in either:

- handling non-composite type cases, as proposed in current change
- handling of both basic and composite type cases in typeprinter through a printing policy

I am happy to follow any of those, though the second might be more disruptive before the branch cut.
So I would rather also introduce handling of decltypes to parameter and return types and land this change.
Because even though it might be messy to hover over nested templated types, I still believe it will most likely save user time in the general case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72498/new/

https://reviews.llvm.org/D72498