[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

Alexandre Ganea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 12 11:47:30 PST 2020


aganea marked 2 inline comments as done.
aganea added inline comments.


================
Comment at: llvm/lib/Support/CrashRecoveryContext.cpp:269
+  const_cast<CrashRecoveryContextImpl *>(CRCI)->HandleCrash(
+      (int)ExceptionInfo->ExceptionRecord->ExceptionCode, ExceptionInfo);
 
----------------
mstorsjo wrote:
> This implicitly converts a pointer to `uintptr_t`, which is an error by default in mingw mode; a cast is needed.
Fixed by rGde797ccdd74f46d5f637ccf66c78da9905a46f42


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70568/new/

https://reviews.llvm.org/D70568





More information about the cfe-commits mailing list