[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

Sun Jan 12 06:51:58 PST 2020

lebedev.ri added a comment.

I agree that the current alias situation is not ideal, though i'm not sure
how much we can fix it since it crosses user interface boundary
(i.e. what fixes won't lead to some regressions from the previous expected behavior)

To be noted, this will make adding of new aliases in non-up-stream modules more involved,
since now the aliases will no longer be confined to the new module, but to the original modules.

Also, there was previously some attempts at this:
https://lists.llvm.org/pipermail/cfe-dev/2017-September/055589.html
D25659 <https://reviews.llvm.org/D25659>
D38171 <https://reviews.llvm.org/D38171>
???

If we proceed as-is, i think we also need one more config switch "CheckAliasesAreEnabled = 1".
And we should completely ignore aliases unless it's enabled.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72566/new/

https://reviews.llvm.org/D72566