[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 12 03:12:49 PST 2020


lebedev.ri added a comment.

A little bit late to the party, but still.
I'm honestly wondering if this should be a proper clang static analyzer data-flow aware check.
This is basically diagnosing every `signed char` -> `signed int` promotion, regardless of whether 
the `char` is used as an ASCII char or not. It really seems like a wrong, noise-filled approach..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71174/new/

https://reviews.llvm.org/D71174





More information about the cfe-commits mailing list