[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Jan 11 08:10:06 PST 2020
njames93 added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/llvm/PreferPreincrementCheck.cpp:38
+ // returned. Reordering those would change the behaviour of the expression.
+ // FIXME: Add any more parents which could use the result of the operation.
+ auto BadParents =
----------------
Mordante wrote:
> Does the checker give a lot of false positives?
First time I tried it there were lots of false positives. But after adding all those Stmt checks it appears to do a rather good job
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72553/new/
https://reviews.llvm.org/D72553
More information about the cfe-commits
mailing list