[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

[Mark de Wever via Phabricator via cfe-commits]

Mordante added a comment.

I only have some naming nits

- incriment -> increment
- decriment -> decrement

Maybe rename the check llvm-prefer-preincrement -> llvm-prefer-pre-increment
and rename the files and classes PreferPreincrementCheck -> PreferPreIncrementCheck



================
Comment at: clang-tools-extra/clang-tidy/llvm/PreferPreincrementCheck.cpp:38
+  // returned. Reordering those would change the behaviour of the expression.
+  // FIXME: Add any more parents which could use the result of the operation.
+  auto BadParents =
----------------
Does the checker give a lot of false positives?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72553/new/

https://reviews.llvm.org/D72553