[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

[Sam McCall via Phabricator via cfe-commits]

sammccall created this revision.
sammccall added reviewers: ilya-biryukov, dgoldman.
Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, jkorous, MaskRay.
Herald added a project: clang.
sammccall added a parent revision: D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties..
sammccall removed a parent revision: D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties..
sammccall marked an inline comment as done.
sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:570
     auto AST = TU.build();
+    EXPECT_THAT(AST.getDiagnostics(), ::testing::IsEmpty()) << Code;
 
----------------
For consistency with the targetDecl() tests in this file, and because I had an error in the testcase that threw me for a loop. I'll try to find a better solution project-wide though.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72508

Files:
  clang-tools-extra/clangd/FindTarget.cpp
  clang-tools-extra/clangd/unittests/FindTargetTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72508.237318.patch
Type: text/x-patch
Size: 5880 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200110/0c79eabf/attachment.bin>