[PATCH] D72500: [clangd] Show hower info for expressions
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 10 05:47:20 PST 2020
sammccall added a comment.
Basing this on the hover for the type doesn't seem right. e.g. `int` should be the `Type` rather than the `Name`.
Rather than printing the value if evaluable, I think we should only show the hover if evaluable. There's a cost to showing it and the value of just the type doesn't seem clearly high enough.
I think we should avoid triggering for literals. Maybe some exceptions, but a hover saying that 0 is an int with value 0 seems silly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72500/new/
https://reviews.llvm.org/D72500
More information about the cfe-commits
mailing list