[PATCH] D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 10 04:21:55 PST 2020


sammccall added a comment.

In D72494#1813875 <https://reviews.llvm.org/D72494#1813875>, @sammccall wrote:

> In D72494#1813719 <https://reviews.llvm.org/D72494#1813719>, @ilya-biryukov wrote:
>
> > Could you also add a test (and possibly support this in the visitors) for `findExplicitReferences`?
>
>
> I've written tests, but it doesn't work and it's not obvious to me yet how to make it work, so I'll do this in a separate patch.


By which I mean, adding the same delegation to the RAV there doesn't work, and I'm not confident that jiggling it around until the test passes is correct here, so I want to understand the traversal behavior a bit better first (RAV has several special cases around OVE/POE)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72494/new/

https://reviews.llvm.org/D72494





More information about the cfe-commits mailing list