[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries
Kan Shengchen via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 10 02:47:09 PST 2020
skan added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2040
+ if (Value.getAsInteger(10, AlignBranchBoundary) ||
+ AlignBranchBoundary < 16 || !llvm::isPowerOf2_64(AlignBranchBoundary)) {
+ D.Diag(diag::err_drv_invalid_argument_to_option)
----------------
MaskRay wrote:
> skan wrote:
> > Any reason for precluding 16?
> I did not preclude 16.
I am sorry that I misunderstood the word "preclude". As far as I know, we would like `AlignBranchBoundary>=32`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72463/new/
https://reviews.llvm.org/D72463
More information about the cfe-commits
mailing list