[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 10 01:00:37 PST 2020


MaskRay marked an inline comment as done.
MaskRay added a comment.

The commutative property (independence of options) makes option composition easier. clangDriver makes heavy use of `getLastArg` and `hasArg`. Without the commutative property, it would now be able to shuffle code around.

The `-malign-branch=jmp -mno-branches-within-32B-boundaries` issue does not matter that much. I do not expect `-mno-branches-within-32B-boundaries` to be used much. If we want to disable branch alignment, `-malign-branch-boundary=0` can be used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72463/new/

https://reviews.llvm.org/D72463





More information about the cfe-commits mailing list