[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 9 23:13:28 PST 2020


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:898
                class $10^Foo {
-                 $11^Foo(int);
+                 $11^Foo(int) {}
                  $12^Foo(): $13^Foo(111) {}
----------------
NIT: is this change redundant now? This was probably a warning, not an error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72355/new/

https://reviews.llvm.org/D72355





More information about the cfe-commits mailing list