[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

Zachary Henkel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 9 20:11:42 PST 2020


zahen added a comment.

My change keeps the diagnostic so consumers can opt into the same enforcement that exists today.  Furthermore, the existing fuzzy-pch.c tests show that new -D flags are allowed under a "clangier" PCH structure.  None of the existing tests error on:

  BAR bar = 17;

when `-DBar=int` is only part of the the test file's command line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72405/new/

https://reviews.llvm.org/D72405





More information about the cfe-commits mailing list