[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

Richard Trieu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 9 18:53:29 PST 2020


rtrieu added inline comments.


================
Comment at: clang/lib/Serialization/ASTReader.cpp:11007
 
+  // Issue any pending ODR-failure diagnostics.
+  for (auto &Merge : RecordOdrMergeFailures) {
----------------
Is this just a copy of the other loop?  That's a lot of code duplication.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71734/new/

https://reviews.llvm.org/D71734





More information about the cfe-commits mailing list