[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 9 14:56:22 PST 2020
Eugene.Zelenko added a comment.
Should be change mentioned in Release Notes?
================
Comment at: clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.cpp:40
- diag(InternalDependency->getBeginLoc(),
+ auto loc_at_fault =
+ Result.SourceManager->getSpellingLoc(InternalDependency->getBeginLoc());
----------------
Please don't use auto when type is not spelled in statement or iterator. Does variable name comply to LLVM Coding Guidelines?
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72484/new/
https://reviews.llvm.org/D72484
More information about the cfe-commits
mailing list