[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

Adhemerval Zanella via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 9 13:32:23 PST 2020


zatrazz added a comment.

In D72449#1812818 <https://reviews.llvm.org/D72449#1812818>, @arichardson wrote:

> I'm fine with this workaround although I'm very surprised that the test is not working. Especially since `deterministic-archive.test` and `replace-update.test` also set TZ to get reproducible output
>
> Do you have access to any of the failing bots? If so what happens there if you change the TZ variable?
>  I get the following on all systems I have access to when I run something like `date && date -u && env TZ=CET date && env TZ=CET date -u && env TZ=BST date && env TZ=BST date -u` I get the following output:
>
>   Thu  9 Jan 2020 20:18:10 GMT
>   Thu  9 Jan 2020 20:18:10 UTC
>   Thu  9 Jan 2020 21:18:10 CET
>   Thu  9 Jan 2020 20:18:10 UTC
>   Thu  9 Jan 2020 20:18:10 UTC
>   Thu  9 Jan 2020 20:18:10 UTC
>


I am not sure now if it was something wrong with the bot tzdata, I reinstalled the tzdata packages
and reconfigured the timezone and now 'TZ=UTC date -d '@0' +%H:%M' does show the expected
00:00.

Indeed, although the workaround shouldn't change the expected result, the issue I am observing
on some machine does not make sense (TZ=UTC date -d '@0' +%H:%M' not showing 00:00).

I will hold this and investigate further.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72449/new/

https://reviews.llvm.org/D72449





More information about the cfe-commits mailing list