[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 9 00:53:03 PST 2020


hans added a comment.

In D70568#1789722 <https://reviews.llvm.org/D70568#1789722>, @hans wrote:

> > The way `Enable()/Disable()` is currently implemented will not work when the tool executes jobs in parallel (ie. llvm-buildozer <https://www.youtube.com/watch?v=usPL_DROn4k> I presented at LLVM conference; or our re-implementation of /MP <https://docs.microsoft.com/en-us/cpp/build/reference/mp-build-with-multiple-processes?view=vs-2019> which I haven't published yet). It needs refcounting, otherwise one instance might disable the CRC while other threads are running, which effectively disables the crash handlers.
> >  But we can discuss that in a separate review if you prefer. I'll remove it from this patch unless you say otherwise.
>
> Yes, I think it would be good to deal with that separately, to allow for incremental progress.


Did you have a chance to look into this any more?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70568/new/

https://reviews.llvm.org/D70568





More information about the cfe-commits mailing list