[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 8 13:18:48 PST 2020


arphaman created this revision.
arphaman added reviewers: rsmith, rjmccall, erik.pilkington, ahatanak.
Herald added subscribers: ributzka, dexonsmith, jkorous.
Herald added a project: clang.

The following commit:

  commit 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573
  Author: Richard Smith <richard-llvm at metafoo.co.uk>
  Date:   Sun Sep 29 05:08:46 2019 +0000
  
      For P0784R7: compute whether a variable has constant destruction if it
      has a constexpr destructor.

started emitting static variables in Objective-C with C++ acquire/release checks. This is not supported for Objective-C. I can't revert the commit right now, so this is a partial revert of the change, to make sure next week's release branch isn't broken.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72411

Files:
  clang/lib/CodeGen/CGDecl.cpp
  clang/test/CodeGenCXX/const-init-cxx2a.cpp
  clang/test/CodeGenObjC/initialize-function-static.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72411.236896.patch
Type: text/x-patch
Size: 3495 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200108/d1ebc2aa/attachment.bin>


More information about the cfe-commits mailing list