[PATCH] D72380: [DataFlow] Factor two worklist implementations out

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 8 12:32:35 PST 2020


xazax.hun marked 2 inline comments as done.
xazax.hun added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowWorklist.h:20
+namespace clang {
+template <typename Comp, unsigned QueueSize> class DataflowWorklistBase {
+  llvm::BitVector EnqueuedBlocks;
----------------
xazax.hun wrote:
> mgehre wrote:
> > Should this class have a bit of doxygen and a unit test?
> We have two users and both users have regression tests. More tests are always good, but I am not sure if we would get much value in this case. Having some comments sound very useful though :)
Added a unit test anyway :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72380/new/

https://reviews.llvm.org/D72380





More information about the cfe-commits mailing list