[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

Wed Jan 8 08:18:47 PST 2020

njames93 added inline comments.

================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146

+- New alias :doc:`llvm-qualified-auto
+  <clang-tidy/checks/llvm-qualified-auto>` to
----------------
Eugene.Zelenko wrote:
> njames93 wrote:
> > Eugene.Zelenko wrote:
> > > njames93 wrote:
> > > > Eugene.Zelenko wrote:
> > > > > njames93 wrote:
> > > > > > Eugene.Zelenko wrote:
> > > > > > > Please move alias entry into aliases section. See previous release for proper order.
> > > > > > I looked at the previous release notes and from what i can see, all alias checks are next to each other in alphabetical order, but there is no special placement of the alias checks in the release notes, they just start at an arbitrary position. 
> > > > > No, aliases are after new checks. See http://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/ReleaseNotes.html.
> > > > Ahh I see, what threw me is there is an alias in release notes in master that is just randomly thrown in the middle, guess I'll change both of them
> > > I think best solution would be to introduce section headers, otherwise people would make similar mistakes during merges in future.
> > Shall I fix the order of everything and add sections then moving forward it should stay consistent?
> It'll be very reasonable fix, especially because of upcoming release, but probably it should be done in separate patch.
I'll leave this as is then

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72217/new/

https://reviews.llvm.org/D72217