[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

Sean Fertile via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 8 07:12:36 PST 2020


sfertile added a comment.

LGTM: I really didn't like setting PIC as the default just to work around some codegen bugs. I believe there are PowerPC codegen tests that will fail with this change though (or perhaps there is a PowerPC leak sanitizer build bot which begins to fail? @stefanp probably knows what exposed the BE issue previously).

A couple minor questions though:  Is there a way to emit a warning if the leak sanitizer is used on ELF powerpc64 and PIC/PIE is not also specified? Where should we document that the leak sanitizer needs additional options for a specific target?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72363/new/

https://reviews.llvm.org/D72363





More information about the cfe-commits mailing list