[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 8 06:16:33 PST 2020


JonasToth added a comment.

In D72217#1807941 <https://reviews.llvm.org/D72217#1807941>, @njames93 wrote:

> What do you think about volatile qualifiers. Personally I don't think its important to qualify an volatile on a pointer that is volatile, but i should adhere to the decl being declared as volatile
>
>   volatile auto X = getPointer();
>   //transform to
>   auto *X volatile = getPointer();
>  
>   auto X = getVolatilePointer();
>   //transform to
>   auto *X = getVolatilePointer();
>


Probably better to stay consistent, especially with `volatile` not being so obvious.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72217/new/

https://reviews.llvm.org/D72217





More information about the cfe-commits mailing list