[clang-tools-extra] d2c9c91 - Move from a long list of checkers to tables

Sylvestre Ledru via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 8 05:45:35 PST 2020


Le 08/01/2020 à 14:14, Alexander Kornienko a écrit :
> [adding the list back]
>
> This list is one of the places that would be quite boring and error-prone to update manually. I'd strongly prefer to have an automatic way of updating it. Detecting whether a check has a fix might be not an easy task though. Maybe the script could use some simple heuristic to detect obvious ways 
> to add a fix (e.g. search for /FixItHint::Create.*\(|fixit::create.*\(/ - maybe in non-comment lines, if it turns out to be feasible - in the check's source files) and mark these checks as having fixes, the ones that don't have the word "fix" most probably don't generate a fix, the rest are 
> "unknown" (and these should be fixed by hand). WDYT?

This is basically what I have done (greping the code to see if there is an autofix).

But I missed modernize-make-unique as it doesn't contain any reference to fixit :/

(I could just update modernize/MakeUniqueCheck.cpp to add a comment)

Cheers,

Sylvestre




More information about the cfe-commits mailing list