[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 8 00:41:39 PST 2020


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:695
+  DeclRelationSet Relations = DeclRelation::Underlying;
+  auto Decls = getExplicitDeclAtPosition(AST, SourceLocationBeg, Relations);
   if (Decls.empty())
----------------
instead of creating a new function, could you rather inline that ? it is the only call site and almost the same with `getDeclAtPosition`.
the comment above (with little modifications) should suffice to explain why `getDeclAtPosition` is not used here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71533/new/

https://reviews.llvm.org/D71533





More information about the cfe-commits mailing list