[PATCH] D72306: [PowerPC] FreeBSD >= 13 default ABI is ELFv2

[Alfredo Dal'Ava Júnior via Phabricator via cfe-commits]

adalava marked an inline comment as done.
adalava added a comment.

In D72306#1807097 <https://reviews.llvm.org/D72306#1807097>, @MaskRay wrote:

> Are you still using -target powerpc64-unknown-freebsd12.0-elfv2 or -target powerpc64-unknown-freebsd12.0-elfv1 added in https://reviews.llvm.org/rL361355 ?


No, we are not using this triplet anymore after decision to OS version to change ABI, nobody is relying on it.
Are you willing to remove it? User can add "-mabi=[elfv1|elfv2]" to override the default ABI for that OS version, anyway.



================
Comment at: clang/lib/Basic/Targets/PPC.h:389
+    if (Triple.getEnvironment() != llvm::Triple::UnknownEnvironment) {
+      switch (Triple.getEnvironment()){
+        case llvm::Triple::ELFv1:
----------------
MaskRay wrote:
> Which ABI does `powerpc64le-linux-gnu` use after this change?
It should be using ELFv2:

[alfredo.junior at FreeBSD_x86 ~/src/llvm-project/build-release-master]$ ./bin/clang -target powerpc64le-linux-gnu -dM -E - < /dev/null | grep CALL_ELF
#define _CALL_ELF 2

Is it ok?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72306/new/

https://reviews.llvm.org/D72306