[clang] 20f005d - [CodeGen][ObjC] Push the properties of a protocol before pushing the

[Akira Hatanaka via cfe-commits]

Author: Akira Hatanaka
Date: 2020-01-06T16:16:02-08:00
New Revision: 20f005d25f488fa1dc69d6792700e014c6a5d165

URL: https://github.com/llvm/llvm-project/commit/20f005d25f488fa1dc69d6792700e014c6a5d165
DIFF: https://github.com/llvm/llvm-project/commit/20f005d25f488fa1dc69d6792700e014c6a5d165.diff

LOG: [CodeGen][ObjC] Push the properties of a protocol before pushing the
properties of the protocol it inherits

This fixes a bug where the type string for a @dynamic property of an
@implementation didn't have 'D' in it when the protocol it conforms to
redeclares the property declared in the base protocol.

rdar://problem/45503561

Added: 
    

Modified: 
    clang/lib/CodeGen/CGObjCMac.cpp
    clang/test/CodeGenObjC/encode-test-2.m

Removed: 
    


################################################################################
diff  --git a/clang/lib/CodeGen/CGObjCMac.cpp b/clang/lib/CodeGen/CGObjCMac.cpp
index e18105fe0193..f36c28a85a68 100644
--- a/clang/lib/CodeGen/CGObjCMac.cpp
+++ b/clang/lib/CodeGen/CGObjCMac.cpp
@@ -3245,9 +3245,6 @@ PushProtocolProperties(llvm::SmallPtrSet<const IdentifierInfo*,16> &PropertySet,
                        SmallVectorImpl<const ObjCPropertyDecl *> &Properties,
                        const ObjCProtocolDecl *Proto,
                        bool IsClassProperty) {
-  for (const auto *P : Proto->protocols())
-    PushProtocolProperties(PropertySet, Properties, P, IsClassProperty);
-
   for (const auto *PD : Proto->properties()) {
     if (IsClassProperty != PD->isClassProperty())
       continue;
@@ -3255,6 +3252,9 @@ PushProtocolProperties(llvm::SmallPtrSet<const IdentifierInfo*,16> &PropertySet,
       continue;
     Properties.push_back(PD);
   }
+
+  for (const auto *P : Proto->protocols())
+    PushProtocolProperties(PropertySet, Properties, P, IsClassProperty);
 }
 
 /*

diff  --git a/clang/test/CodeGenObjC/encode-test-2.m b/clang/test/CodeGenObjC/encode-test-2.m
index 2985fbda1862..2d9593d65b0c 100644
--- a/clang/test/CodeGenObjC/encode-test-2.m
+++ b/clang/test/CodeGenObjC/encode-test-2.m
@@ -6,6 +6,9 @@
 // CHECK: private unnamed_addr constant [16 x i8] c"@\22Foo<X><Y><Z>\22\00",
 // CHECK: private unnamed_addr constant [13 x i8] c"{Intf=@@@@#}\00",
 
+// CHECK: @[[PROP_NAME_ATTR:.*]] = private unnamed_addr constant [5 x i8] c"T@,D\00",
+// CHECK: @"_OBJC_$_PROP_LIST_C0" = internal global { i32, i32, [1 x %{{.*}}] } { i32 8, i32 1, [1 x %{{.*}}] [%{{.*}} { {{.*}}, i8* getelementptr inbounds ([5 x i8], [5 x i8]* @[[PROP_NAME_ATTR]], i32 0, i32 0) }] },
+
 @protocol X, Y, Z;
 @class Foo;
 
@@ -29,3 +32,18 @@ int main()
 {
 	const char * en = @encode(Intf);
 }
+
+ at protocol P0
+ at property id prop0;
+ at end
+
+ at protocol P1 <P0>
+ at property id prop0;
+ at end
+
+ at interface C0 <P1>
+ at end
+
+ at implementation C0
+ at dynamic prop0;
+ at end