[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`
Logan Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 6 11:03:52 PST 2020
logan-5 added inline comments.
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unintended-adl.rst:35
+
+ If non-zero, ignores calls to overloaded operators using the operator syntax (e.g. `a + b`), but not the function call syntax (e.g. `operator+(a, b)`). Default is `1`.
+
----------------
Eugene.Zelenko wrote:
> Indentation. Please use double back-ticks for a + b and operator+(a, b).
I'm not sure what you would like me to change about the indentation. This follows the same format (three spaces) I've found in the documentation for other checks.
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unintended-adl.rst:39
+
+ Semicolon-separated list of names that the check ignores. Default is `swap`.
----------------
Eugene.Zelenko wrote:
> Indentation. Please use double back-ticks for swap (or std::swap?).
Since the 'swap' here is referring to the default value of the option string, shouldn't it just be single backticks?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72282/new/
https://reviews.llvm.org/D72282
More information about the cfe-commits
mailing list