[PATCH] D72221: Support function attribute patchable_function_entry
Nick Desaulniers via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 6 10:54:00 PST 2020
nickdesaulniers added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:826
+ "patchable-function-entry",
+ (Twine(Attr->getSize()) + "," + Twine(Attr->getStart())).str());
}
----------------
ostannard wrote:
> I think using two function attributes here would be better, to avoid needing to parse this again later.
In that case, it would not make sense to have start without a size, and thus should be checked for in the verification.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72221/new/
https://reviews.llvm.org/D72221
More information about the cfe-commits
mailing list