[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added inline comments.


================
Comment at: clang/lib/Analysis/UninitializedValues.cpp:856
+        vals[VD] = MayUninitialized;
 }
 
----------------
Can you walk me through the logic of this function?

I would assume for changes to `asm goto`, the above early `return` would have been removed? Otherwise we seem to be changing the logic of the non-`asm goto` case?


================
Comment at: clang/test/Analysis/uninit-asm-goto.cpp:57
+  return y;
+indirect:
+  return -2;
----------------
nickdesaulniers wrote:
> I think if you left out `indirect`, it would be clearer what this test is testing.
bump


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71314/new/

https://reviews.llvm.org/D71314