[PATCH] D72221: Support function attribute patchable_function_entry

[Oliver Stannard (Linaro) via Phabricator via cfe-commits]

ostannard added inline comments.


================
Comment at: clang/include/clang/Basic/AttrDocs.td:3995
+``__attribute__((patchable_function_entry(N,M)))`` is used to generate M NOPs
+before the function entry and N-M NOPs after the function entry. This attributes
+takes precedence over command line option ``-fpatchable-function-entry=N,M``.
----------------
Grammar nits:
s/attributes/attribute/
over _the_ command line option


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:826
+          "patchable-function-entry",
+          (Twine(Attr->getSize()) + "," + Twine(Attr->getStart())).str());
   }
----------------
I think using two function attributes here would be better, to avoid needing to parse this again later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72221/new/

https://reviews.llvm.org/D72221