[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 6 06:17:45 PST 2020


erichkeane added a comment.

I'm concerned about just making this fallthrough to 'false'.  These ARE integral promotions, we just don't know the type size. What happens if you instantiate this template?  Will it still give the correct answer/type/diagnosis?

In the case of the crash, I would suspect that the expression 'if (c)' should just be dependent and skipped from the semantic analysis because of it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72242/new/

https://reviews.llvm.org/D72242





More information about the cfe-commits mailing list