[PATCH] D72241: [clang-tidy] new altera single work item barrier check

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

I think will be good idea to separate module code in own review or refer to previous one of previous reviews as dependency.



================
Comment at: clang-tidy/altera/SingleWorkItemBarrierCheck.cpp:51
+    if (Attribute->getKind() == attr::Kind::ReqdWorkGroupSize) {
+      auto RWGSAttribute =
+          static_cast<const ReqdWorkGroupSizeAttr *>(Attribute);
----------------
const auto *.


================
Comment at: clang-tidy/altera/SingleWorkItemBarrierCheck.cpp:69
+  } else {
+    if (IsNDRange == true) { // No warning if kernel is treated as an NDRange.
+      return;
----------------
Just IsNDRange. See readability-simplify-boolean-expr.


================
Comment at: docs/clang-tidy/checks/altera-single-work-item-barrier.rst:51
+
+   Defines the version of the Altera Offline Compiler. Defaults to 1600
+   (corresponding to version 16.00).
----------------
Please highlight 1600 with single back-quotes.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72241/new/

https://reviews.llvm.org/D72241