[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

[Kristina Brooks via Phabricator via cfe-commits]

kristina accepted this revision.
kristina added a comment.

On second look this seems to be caused by `compiler-rt` being used as the default runtime, which is not accounted for in that particular test.

Test is expecting a GCCesque crtbegin here which is missing with `compiler-rt`:

  "crt1.o" "crti.o" "/o/b/llvm-test/v10.0.4010/bin/../lib/clang/10.0.4010/lib/linux/clang_rt.crtbegin-x86_64.o"

Which fails for obvious reasons:

  llvm-project/clang/test/Driver/cross-linux.c:62:26: error: CHECK-MULTI32-X86-64: expected string not found in input
  // CHECK-MULTI32-X86-64: "crti.o" "[[gcc_install:.*/Inputs/multilib_32bit_linux_tree/usr/lib/gcc/i386-unknown-linux/4.6.0]]/64{{/|\\\\}}crtbegin.o"

This seems unrelated, apologies for the false alarm, I'll have to look into fixing the test for when `compiler-rt` is the default CRT myself.

I'm happy to sign off on this. Let me know if you need this committed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69758/new/

https://reviews.llvm.org/D69758