[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added a comment.

In D54943#1804905 <https://reviews.llvm.org/D54943#1804905>, @0x8000-0000 wrote:

> In D54943#1804904 <https://reviews.llvm.org/D54943#1804904>, @JonasToth wrote:
>
> > In D54943#1804890 <https://reviews.llvm.org/D54943#1804890>, @0x8000-0000 wrote:
> >
> > > I can't build this on top of current llvm-project tree (6a6e6f04ec2cd2f4f07ec4943036c5c2d47ce0c7 <https://reviews.llvm.org/rG6a6e6f04ec2cd2f4f07ec4943036c5c2d47ce0c7>):
> > >
> > >   /usr/bin/ld: lib/libclangTidyCppCoreGuidelinesModule.a(ConstCorrectnessCheck.cpp.o): in function `clang::tidy::cppcoreguidelines::ConstCorrectnessCheck::registerMatchers(clang::ast_matchers::MatchFinder*)':
> > >   /home/florin/tools/llvm-project/clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:65: undefined reference to `clang::ast_matchers::decompositionDecl'
> > >
> > >
> > > I am building using clang++-9 from Debian, and diff7 applied cleanly.
> > >
> > > Jonas, is it possible to rebase this on top of llvm-project and push it to a branch on https://github.com/JonasToth/llvm-project ?
> >
> >
> > I just merged master into the branch and pushed to `feature_transform_const.patch` branch in my fork. Maybe that works?
> >  If you want you can join IRC, its faster to get this fixed there :)
>
>
> Strange - I have checked out your branch, and the patch is correct (no difference between when I apply the phabricator diff7 on top of upstream llvm-project and when i look at feature_transform_const.patch)
>
> I am using the following cmake configuration:
>
>   cmake ../llvm \
>      -DCMAKE_INSTALL_PREFIX=/opt/clang10 \
>      -DCMAKE_C_COMPILER=/usr/bin/clang-9 \
>      -DCMAKE_CXX_COMPILER=/usr/bin/clang++-9 \
>      -DCMAKE_BUILD_TYPE=Debug \
>      -DLLVM_TARGETS_TO_BUILD=X86 \
>      -DLLVM_ENABLE_THREADS=On \
>      -DLLVM_INSTALL_TOOLCHAIN_ONLY=On \
>      -DLLVM_USE_SPLIT_DWARF=On \
>      -DLLVM_BUILD_TESTS=ON \
>      -DLLVM_ENABLE_PROJECTS="clang;libcxx;libcxxabi;libunwind;lldb;compiler-rt;lld;clang-tools-extra;" \
>      -GNinja
>
>
> What cmake configuration are you using?
>
> (Sorry - I need to go, no time for IRC today)


soooo weird. it builds both on my laptop and my workstation with comparable configuration (not debug, but RelWithDebInfo). i do use lld and ninja, not sure if that makes any difference (it shouldnt)
i have no idea why it does not link. are those builds clean?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54943/new/

https://reviews.llvm.org/D54943