[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added a comment.

i think it would be easier to review if there are two patches, one refactoring and one new check.



================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:59
+  struct FailureInfo {
+    std::string KindName; // Tag or misc info to be used as derived classes need
+    std::string Fixup;    // The name that will be proposed as a fix-it hint
----------------
I think the `kind` should be an enum instead of stringly typing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72213/new/

https://reviews.llvm.org/D72213