[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added a comment.

In D54943#1804183 <https://reviews.llvm.org/D54943#1804183>, @0x8000-0000 wrote:

> This patch does not build on top of current tree:
>
>   /usr/bin/ld: lib/libclangTidyCppCoreGuidelinesModule.a(ConstCorrectnessCheck.cpp.o): in function `clang::tidy::cppcoreguidelines::ConstCorrectnessCheck::registerMatchers(clang::ast_matchers::MatchFinder*)':
>   /home/florin/tools/llvm-project/clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:65: undefined reference to `clang::ast_matchers::decompositionDecl'
>   clang: error: linker command failed with exit code 1 (use -v to see invocation)
>   [2771/4997] Building CXX object tools/clang/tools/extra/clang-include-fixer/find-all-symbols/CMakeFiles/obj.findAllSymbols.dir/PragmaCommentHandler.cpp.o
>   ninja: build stopped: subcommand failed.
>
>
> This is my top of the tree right now:
>
>   b7ecf1c1c373c53183ef6ef66efbe4237ff7b96d (origin/master, origin/HEAD, master) NFC: Fix trivial typos in comments
>


did the changes to `clang/include/clang/ASTMatchers/ASTMatchers.h` and `clang/lib/ASTMatchers/Dynamic/Registry.cpp` apply? They provide the `decompositionDecl` matcher. It seems odd, they are not available :/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54943/new/

https://reviews.llvm.org/D54943