[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 3 11:40:59 PST 2020
rjmccall added inline comments.
================
Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91
bool InAllocaSRet : 1; // isInAlloca()
+ bool InAllocaIndirect : 1;// isInAlloca()
bool IndirectByVal : 1; // isIndirect()
----------------
Would it be better to handle `inalloca` differently, maybe as a flag rather than as a top-level kind? I'm concerned about gradually duplicating a significant amount of the expressivity of other kinds.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72114/new/
https://reviews.llvm.org/D72114
More information about the cfe-commits
mailing list