[PATCH] D72121: [clang-tidy] Fix readability-identifier-naming missing member variables

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 3 10:43:12 PST 2020


JonasToth added a comment.

In D72121#1803242 <https://reviews.llvm.org/D72121#1803242>, @njames93 wrote:

> Ahh clang format script must have run, I'll undo that. I've not tried running it against the whole of llvm as I don't know what the easy way to do that is, especially given that llvm disregards it's standard naming convention for old projects and stl like containers. The comment is just in relation to the bug report that this fix is based on, could probably go


yeah clang-format tends to do that, as devs do not consistently apply automatic formatting :/

for llvm: https://clang.llvm.org/docs/HowToSetupToolingForLLVM.html
You can use `run-clang-tidy.py` in the `tools/` directory of clang-tidy. Then specify your custom built clang-tidy binary.

The call should like similar to this (not tested):
`<path-to-llvm>/llvm-project $ run-clang-tidy.py -p <path-to-build-dir-with-compile-commands> -clang-tidy-binary <path-to-build> -checks=-*,readability-identifier-naming -fix clang/lib`

That will run over clang/libs only. If you choose `lib/` it will run over each `lib`-subdirectory of the project.

Maybe you can still try it out and see what diagnostics you get. It will be a good practice anyway, if you plan to keep developing :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72121/new/

https://reviews.llvm.org/D72121





More information about the cfe-commits mailing list